Add [[nodiscard]] to Rectangle::translated

jellebakker · September 15, 2023, 9:52am

Could you add [[nodiscard]] to Rectangle::translated to prevent mixing it up with translate?

juce-framework/JUCE/blob/develop/modules/juce_graphics/geometry/juce_Rectangle.h#L327


      
          //==============================================================================

          /** Moves the rectangle's position by adding amount to its x and y coordinates. */

          void translate (ValueType deltaX,

                          ValueType deltaY) noexcept

          {

              pos.x += deltaX;

              pos.y += deltaY;

          }

          

          /** Returns a rectangle which is the same as this one moved by a given amount. */

          Rectangle translated (ValueType deltaX,

                                ValueType deltaY) const noexcept

          {

              return { pos.x + deltaX, pos.y + deltaY, w, h };

          }

          

          /** Returns a rectangle which is the same as this one moved by a given amount. */

          Rectangle operator+ (Point<ValueType> deltaPosition) const noexcept

          {

              return { pos.x + deltaPosition.x, pos.y + deltaPosition.y, w, h };

          }

Thanks,

Jelle

t0m · September 15, 2023, 4:02pm

Yes, that’s a good suggestion.

Add [[nodiscard]] to Rectangle::translated

Purchase

Discover

Learn

Support

About

Events