AudioPluginInstance deprecated virtuals aren't being callled

In the past years JUCE compiled a great breaking change document,
If I understand correctly deprecation, it means it WILL be removed (in a future tense).

So JUCE now has many virtuals on AudioPluginInstance that are pretty much deadcode not being called.

 	JUCE_DEPRECATED (String getParameterID(int index) override)
 
 	JUCE_DEPRECATED (float getParameter(int parameterIndex) override)
 
 	JUCE_DEPRECATED (void setParameter(int parameterIndex, float newValue) override)
 
 	JUCE_DEPRECATED (const String getParameterName(int parameterIndex) override)
 
 	JUCE_DEPRECATED (String getParameterName(int parameterIndex, int maximumStringLength) override)
 
 	JUCE_DEPRECATED (const String getParameterText(int parameterIndex) override)
 
 	JUCE_DEPRECATED (String getParameterText(int parameterIndex, int maximumStringLength) override)
 
 	JUCE_DEPRECATED (int getParameterNumSteps(int parameterIndex) override)
 
 	JUCE_DEPRECATED (bool isParameterDiscrete(int parameterIndex) const override)
 
 	JUCE_DEPRECATED (bool isParameterAutomatable(int parameterIndex) const override)
 
 	JUCE_DEPRECATED (float getParameterDefaultValue(int parameterIndex) override)
 
 	JUCE_DEPRECATED (String getParameterLabel(int parameterIndex) const override)
 
 	JUCE_DEPRECATED (bool isParameterOrientationInverted(int parameterIndex) const override)
 
 	JUCE_DEPRECATED (bool isMetaParameter(int parameterIndex) const override)
 
 	JUCE_DEPRECATED (AudioProcessorParameter::Category getParameterCategory(int parameterIndex) const override)

You can create a simple demo audio plugin, add a parameter -

    p.reset (new AudioParameterFloat("param",
                                     "param",
                                     NormalisableRange<float>(),
                                     0.0f));
    addParameter(p.get());

and override any of the above with jassertfalse. they’re deprecated but simply not being called.

They’re only being called in the LegacyAudioParameter. so it worth adding as a breaking change since now the default inherited parameter won’t call any of those…

1 Like