[BR] Windows 11 is reported as Windows 10 using juce::SystemStats

ImJimmi · July 21, 2022, 2:06pm

Sorry if this has already been reported - I couldn’t find any other topics on the matter…

Using juce::SystemStats::getOperatingSystemName() is returning "Windows 10" on Windows 11 machines.

It looks as though the current way JUCE checks for Windows version numbers may not be sufficient for handling Windows 11 since, according to this page (which I’m not sure how reliable it is), the version number of Windows 11 is still 10.0, but with a different build number.

Looks like juce::SystemStats::getOperatingSystemType() may need to check the build number, as well as the major and minor versions?

github.com

juce-framework/JUCE/blob/980092ba1a8496b4134a00e963e50025f83bc3c7/modules/juce_core/native/juce_win32_SystemStats.cpp#L254


      
              auto major = (v >> 16) & 0xff;

              auto minor = (v >> 0)  & 0xff;

             #else

              auto versionInfo = getWindowsVersionInfo();

              auto major = versionInfo.dwMajorVersion;

              auto minor = versionInfo.dwMinorVersion;

             #endif

          

              jassert (major <= 10); // need to add support for new version!

          

              if (major == 10)                 return Windows10;

              if (major == 6 && minor == 3)    return Windows8_1;

              if (major == 6 && minor == 2)    return Windows8_0;

              if (major == 6 && minor == 1)    return Windows7;

              if (major == 6 && minor == 0)    return WinVista;

              if (major == 5 && minor == 1)    return WinXP;

              if (major == 5 && minor == 0)    return Win2000;

          

              jassertfalse;

              return UnknownOS;

          }

attila · August 4, 2022, 8:02pm

Thank you for reporting this. A fix has been pushed to develop

ImJimmi · August 4, 2022, 8:09pm

Amazing, thanks Attila!

Topic		Replies	Views
getOperatingSystemName() Does not return Windows 10 General JUCE discussion	4	1153	May 31, 2016
BUG: SystemStats::getOperatingSystemName() on Windows 10 General JUCE discussion	31	3308	October 23, 2018
SystemStats::getOperatingSystemType assertion fails on macOS 11.1 MacOSX and iOS	4	718	December 16, 2020
[bug] Some strange system info stats in Juce demo Windows	3	718	May 4, 2017
getOperatingSystemType() returns wrong OS type with some DAW Audio Plugins	3	1134	April 28, 2016

[BR] Windows 11 is reported as Windows 10 using juce::SystemStats

Purchase

Discover

Learn

Support

About

Events

[BR] Windows 11 is reported as Windows 10 using juce::SystemStats

Related topics

Purchase

Discover

Learn

Support

About

Events