Just wanted to point out that this change set breaks creating two file readers that reference the same physical audio file. This is because the call to createInputStream() now fails on the second instance.
Apparently adding the new FILE_SHARE_DELETE flag causes a second call to CreateFile to fail with a permissions error. This will likely cause a lot of regressions in code where people try to create a reader from the same file twice.
Author: ed email@example.com
Date: 12/4/2018 7:44:37 AM
Windows: Add the FILE_SHARE_DELETE when opening file handles to allow them to be renamed and deleted