BufferingAudioReader::readSamples return value seems buggy?

If this method times out, it returns the latest state of success - which might be true. This seems counter intuitive and not very helpful for the ways I’d like to use the class. Why not set success to false in this case?
Also, if there are blocks, success is set to the state of the last block used for the request, which may hide errors in an earlier block. Shouldn’t this also be change to:
success = success && block->success;

1 Like