BUG in getTypeOfChannel()

General JUCE discussion
1

Hi Guys,

i think i unearthed another bug.

For example the channel order of 9.1.6 should be (from the comment):

(left, right, centre, LFE, leftSurroundSide, rightSurroundSide, leftSurroundRear, rightSurroundRear, wideLeft, wideRight, topFrontLeft, topFrontRight, topSideLeft, topSideRight, topRearLeft, topRearRight)

But getTypeOfChannel() returns the channel types in a different order when cycling through from 0 to 15.

Now, is that a bug or am i delusional?

Best,

Thomas

1 Like
2

I believe this is working as intended.

It’s not clear from the doc strings (we could be improve that), but channels are effectively sorted by their enum value. This means, when calling getTypeOfChannel() in a loop from 0 to N, the result will increase monotonically. The doc strings for the channel layouts provide the types of channels that are included, but not necessarily the orders.

In the example you gave, the actual order should be:

  • left (1)
  • right (2)
  • centre (3)
  • lfe (4)
  • leftSurroundSide (10)
  • rightSurroundSide (11)
  • topFrontLeft (13)
  • topFrontRight (15)
  • topRearLeft (16)
  • topRearRight (18)
  • leftSurroundRear (20)
  • rightSurroundRear (21)
  • wideLeft (22)
  • wideRight (23)
  • topSideLeft (28)
  • topSideRight (29)

Listing the channels in this order in the docs would arguably make them more difficult to parse because the ‘top’ speakers are mixed in with the ‘ear-level’ speakers.

3

@reuk Ok, got it. Yeah it is a bit confusing. Thanks for the clarification.

Is there a reason for using a Biginteger for all that with this kind of intransparent bit juggling instead of a simple std::vector < AudioChannelSet::ChannelType > for managing the different layouts? My guess is it would make things much more easy to understand, manage and debuggable…