Bug in juce::dsp::Convolution::Pimpl::loadImpulseResponse()

Development
1

Hi,

Currently when loading impulse responses there is no check if the created FileInputStream is ok or not. If it’s not (like I currently have in my app because of Apple’s security restrictions) it will cause infinite loop of trying to load the impulse file.

else if (currentInfo.sourceType == SourceType::sourceAudioFile)
    {
        if (! (copyAudioStreamInAudioBuffer (new FileInputStream (currentInfo.fileImpulseResponse))))
            return;
    }

Could be fixed with something like this (I don’t know internals of the class so I’m not sure if this is a valid fix or not:

    else if (currentInfo.sourceType == SourceType::sourceAudioFile)
    {
        auto stream = new FileInputStream(currentInfo.fileImpulseResponse);

        if (stream->openedOk()){
            if (! copyAudioStreamInAudioBuffer (stream))
                return;
        }
        else {
            currentInfo.sourceType = SourceType::sourceNone;
        }
    }