if (! Symbols::symbol (lib, symbols.plan_dft_fftw, "fftwf_plan_dft_1d")) return nullptr;
if (! Symbols::symbol (lib, symbols.plan_r2c_fftw, "fftwf_plan_dft_r2c_1d")) return nullptr;
if (! Symbols::symbol (lib, symbols.plan_c2r_fftw, "fftwf_plan_dft_c2r_1d")) return nullptr;
if (! Symbols::symbol (lib, symbols.destroy_fftw, "fftwf_destroy_plan")) return nullptr;
if (! Symbols::symbol (lib, symbols.execute_dft_fftw, "fftwf_execute_dft")) return nullptr;
if (! Symbols::symbol (lib, symbols.execute_r2c_fftw, "fftwf_execute_dft_r2c")) return nullptr;
if (! Symbols::symbol (lib, symbols.execute_c2r_fftw, "fftwf_execute_dft_c2r")) return nullptr;
#endif
return new FFTWImpl (std::move (lib), symbols);
}
return nullptr;
}
FFTWImpl (size_t orderToUse, DynamicLibrary&& libraryToUse, const Symbols& symbols)
: fftwLibrary (std::move (libraryToUse)), fftw (symbols), order (static_cast<size_t> (orderToUse))
{
ScopedLock lock (getFFTWPlanLock());
Shouldn’t this line be something like this:return new FFTWImpl (order, std::move (lib), symbols);
The constructor of FFTWImpl isFFTWImpl (size_t orderToUse, DynamicLibrary&& libraryToUse, **const** Symbols& symbols)
Otherwise it won’t compile if you want to use the FFTW
How did this get into the master branch?
ed95
February 21, 2019, 9:15am
3
Whoops. I’ll get that sorted out, thanks.
Thanks! Any chances to cherrypick this to the master branch? Our CI will most definitely fail once we’ve moved from 5.4.1 to 5.4.2 using the master branch.
ed95
February 21, 2019, 10:15am
5
We’ll be doing a minor bugfix release in the next few days so it’ll make it’s way onto the master branch then.
1 Like
