FR: Option to change the toolbar's customisation dialog background colour from all white

Feature Requests
1

At them moment there seems to be no way to change the background colour for the customisation dialog from all white.

Seems hard coded in the constructor.

The dialog itself is private and I don’t think there is any way to override this behaviour without rolling my own.

I think this could be a good solution as the icon colours have to work with the toolbar’s background colour any way.:

CustomisationDialog (ToolbarItemFactory& factory, Toolbar& bar, int optionFlags) : DialogWindow (TRANS ("Add/remove items from toolbar"), bar.findColour (Toolbar::backgroundColourId), true, true), toolbar (bar)

2

Bumping this issue, because:

I think it is not really a feature request but a bug report, as assuming the background should be white is plan wrong. It was good as a proof of concept, but not in a product.

Using the Toolbar customisation in a dark theme is impossible without that fix. The buttons are invisible.

Since the buttons displayed are the same as on the toolbar, it would be appropriate to use the same background colour from the toolbar or add an additional Toolbar::customisationBackgroundColourId, if you are worried about breaking changes.

A personal note: this is the only bug we have to patch in our CI… please help us to get rid of this necessity.

3

Thank you for reporting the issue. A change is out on develop

3 Likes
4

Thanks for looking into this!
This works perfectly.