MidiMessageSequence::addSequence


#1

messages timeStamped at exactly lastAllowableTime are not actually allowed as the check is…

rather than

is this meant?

took me ages to track down a bug where my final noteOffs were being cut off due to this behavior.

I’m new to Midi coding so I may be doing things oddly, hence my finding this.

klf


#2

Yes, that’s how I intended it to work, since normally if your buffer length is x, you’d pass in x as the length you want, and would expect only values less than x to be included (because an offset of x would be in the next buffer)

I’ll make the comments clearer about this though, it’s a bit misleading.


#3

ah see. fairy nuff.

what I was doing was adding two mms together of differing lengths…


#4