Well, yes:
-
it’ll seem to be ignored at first because I’m sure the whole team have each already seen this and thought the same thing: “ah, that’s a good idea but I bet he won’t have implemented it for all platforms… have a quick look at the code… nope. It needs an openGL and CoreGraphics version, so that’s going to be a ton of work for someone, we’ll need to put it on the backlog somewhere, and then will need to decide if it should wait until after we’ve done other work on new rendering engines anyway (…and other considerations…)”
-
then yes: it will be completely rewritten, because even at a quick glance, I saw a bunch of things there that don’t match our style guidelines, not to mention that it needs about another 1000 lines of code adding for the other platforms, which will probably then mean some D.R.Y refactoring of the stuff that he did write, not to mention writing some tests for it. A production-ready version of this PR won’t have much in common with the one that’s there.
@kraken It’s easy to be sarcastic about this kind of thing when it’s not you who has to actually do it. We are grateful for contributions, but you need to understand that it’s not just a case of us clicking “accept” and moving on. I wish it was!
