PopupMenu Text colour

[daniel]

They should also obey the colours set to the LookAndFeel. In the juce LookAndFeels the PopupMenu of a ComboBox only follows the LookAndFeel, not the ComboBox it is targeting, see here:

Setting ComboBox's PopupMenu colors

Yes, this intentionally tries to avoid changing the behaviour of existing LookAndFeel classes. The existing behaviour doesn’t feel “broken” enough to change it, and modifying the colour lookup mechanism might silently change the styling of peoples’ apps which I’d prefer not to do without a strong reason. For now this feels like a good middle-ground between allowing more flexible theming without requiring users to test and rework too much code. Maybe I’ve missed a better solution that would work…

You can find fixes in the various posts in that thread where I worked around it, but they all involve patching the LookAndFeel to get the colour from the targetComponent rather than from the LookAndFeel.findColour().

This is the crucial function to add and to use:

LookAndFeels/foleys_JuceLookAndFeels.cpp