Question about ChildProcessMaster and jassert


#1

Should this call to kill really be in jassert?

bool ChildProcessMaster::launchSlaveProcess (const File& executable, const String& commandLineUniqueID, int timeoutMs, int streamFlags)
{
    connection = nullptr;
    jassert (childProcess.kill());
...

What if I (or any user) expects this function to attempt killing the child in a release build? No biggie if the jassert is intended. I’ll just copy these files and hack em’ up :slight_smile:


#2

Good question - I think it’s just there to detect things going wrong, since at that point the child process should have been cleanly stopped, so if it’s still running, something has failed. But I’ll double-check and make the code more self-explanatory to avoid confusion!


#3

Ok thanks Jules!