ResizableWindow::restoreStateFromString()

[valley]

line 504:

r = r.getIntersection (screen);

This seems wrong to me, as unless there’s some cleverness elsewhere, it’ll collapse any window that lies outside of the viewport. I.E. if a secondary screen is removed, then screen will address the single desktop area, but if r might still be referencing the second display. The intersection then would be zero. Even in the best case scenario, the window will be shrunk, rather than relocated.

Wouldn’t it be better to just brute force it with something like:

if (!screen.contains(r))
{
int w = r.getWidth() < screen.getWidth() ? r.getWidth() : screen.getWidth();
int h = r.getHeight() < screen.getHeight() ? r.getHeight() : screen.getHeight();
int l = r.getX() >= screen.getX() ? screen.getX() : r.getX();
int t = r.getY() >= screen.getY() ? screen.getY() : r.getY();
if (l + w > screen.getRight()) l = screen.getRight() - w;
if (t + h > safe.getBottom()) t = screen.getBottom() - h;
setBounds(l, t, w, h);
}

(untested)

Here, I’m assuming the screen is pre-constrained for taksbar/dock etc.

[jules]

…yes, that does seem a bit wrong. My suggestion would be this:

    if (! screen.contains (r))
    {
        r.setSize (jmin (r.getWidth(), screen.getWidth()),
                   jmin (r.getHeight(), screen.getHeight()));

        r.setPosition (jlimit (screen.getX(), screen.getRight() - r.getWidth(), r.getX()),
                       jlimit (screen.getY(), screen.getBottom() - r.getHeight(), r.getY()));
    } 

(also untested, and probably basically the same as your code…)

[valley]

That seems to be working out fine.