TODO/xxx comments are dust collectors

General JUCE discussion
1

At the risk of being “the bad guy,” I just wanted to remind that there are many comments containing TODO and xxx, and they have remained for years.

Not all comments are possible to fix/support/complete (eg: not supported on the platform), so it may be wise to sift through them and remove those.

And also, I’d like to point out that grepping for either of these keywords shows many in Android and Linux.

With that, it may be helpful to the JUCErs to add visibility to the TODO/xxx comments in progress - in the forum as per the usual, or even via the GitHub Issue tracker.

Examples needing the shame bell rung:

// juce_android_Files.cpp
// Let's pack the user's system. We can just pretend deletion happened together!

bool File::moveToTrash() const
{
    if (! exists())
        return true;

    // TODO
    return false;
}

// From BigIntegerTests:
// YOLO

// TODO: should add tests for other ops (although they also get pretty well tested in the RSA unit test)

// juce_android_FileChooser.cpp
// Silently break this feature on Android.

void FileChooser::showPlatformDialog (Array<File>& /*results*/,
                                      const String& /*title*/,
                                      const File& /*currentFileOrDirectory*/,
                                      const String& /*filter*/,
                                      bool /*selectsDirectory*/,
                                      bool /*selectsFiles*/,
                                      bool /*isSaveDialogue*/,
                                      bool /*warnAboutOverwritingExistingFiles*/,
                                      bool /*selectMultipleFiles*/,
                                      bool /*treatFilePackagesAsDirs*/,
                                      FilePreviewComponent* /*extraInfoComponent*/)
{
    // TODO
1 Like