Typo in juce_VST3_Wrapper.cpp


#1

Hi,

In juce_VST3_Wrapper.cpp line 1486:
bank.magic1 = (int32) htonl ('FBCh');

should be replaced with:
bank.magic2 = (int32) htonl ('FBCh');

(since magic1 already contains the ‘CcnK’ id)


#2

uh oh. this will probably lead to a preset/user song/project breaking fix. Thankfully it at least is only used if JUCE_VST3_CAN_REPLACE_VST2 is enabled.


#3

I don’t think it breaks anything, the current code is already throwing a juce assert when a vstpreset file is loaded , but I think that’s the only check on the fxp bank header


#4

This was fixed in JUCE 5.0.1. Thanks for reporting.