Calling setValueNotifyingHost() from processBlock()

[yfede]

@jules

I was suggesting having a thread-local variable “isAudioThread”, which is set to true at the start of process() and set to false at the end.

Ah yes, I misunderstood your proposal, I figured you wanted to set the flag to “true” upon first processBlock to “tag” the thread from then on, which is something that I considered myself for exactly this purpose.

Regarding your idea, it is equivalent to having a method that informs whether the AudioProcessor::getCallbackLock() is taken by the current thread.

On one hand, that’s a facility that is already available for the special case of the MessageManagerLock, so I don’t see why not adding it also for the callback lock.

But on the other hand, I remember that when I suggested implementing something like that several years ago for CriticalSection, you dismissed the idea with valid arguments (can’t remember now), probably linked to the fact that one could write code that waited for the lock without actually locking, which seemed a bad idea.

EDIT: found it, 8 years have passed, maybe something has changed in the mean time:

Is there a way to test if my code is already holding a lock

The same way I can test whether the current thread has locked the MessageManager with MessageManager::currentThreadHasLockedMessageManager (), is there a way to test whether the current thread is currently holding the lock to a generic CriticalSection? The purpose is to trigger a jassert if one of my methods is being called while its caller is NOT holding the lock.