Commit 03b86ce breaks my plugin

1

I’m getting terrible feedback with this change…

    void setTargetValue (FloatType newValue) noexcept
    {
//        if (approximatelyEqual (newValue, this->target))     // <<<<  These were removed
//            return;
    
        if (stepsToTarget <= 0)
        {
            this->setCurrentAndTargetValue (newValue);
            return;
        }

        // Multiplicative smoothed values cannot ever reach 0!
        jassert (! (std::is_same_v<SmoothingType, ValueSmoothingTypes::Multiplicative>
                    && approximatelyEqual (newValue, (FloatType) 0)));

        this->target = newValue;
        this->countdown = stepsToTarget;

        setStepSize();
    }

Standalone plugin (synth) even if I just click on the TEST button in the Audio setup dialog.

Rail

2

Looks like you would want to revert to the original (28414a6):

if (newValue == this->target)
    return;

Rail

3

There’s a fix restoring the approximatelyEqual on its way.

1 Like