FR: Improve documentation of createPluginFilter()

Just ran into the problem of having an undefined symbol: createPluginFilter() error because I’d mistakenly placed the definition of the function in a namespace.

The documentation of createPluginFilter states:

/** Somewhere in the codebase of your plugin, you need to implement this function
and make it return a new instance of the filter subclass that you’re building.
*/

This is a little misleading because the function must be defined in the global namespace, so not just “somewhere in the codebase”.

Perhaps the documentation could be updated to something like:

Somewhere in the global namespace of your plugin’s codebase, you need to implement this function and make it return a new instance of the filter subclass that you’re building.

OMG YOU ARE A LEGEND THANK YOU SO MUCH!! I was trying to figure this out for hours. In the back of my mind I thought it could’ve been the namespace, but it didn’t seem like that should be an issue so I didn’t both changing everything back until I saw this.

2 Likes