juce_ios_UIViewComponentPeer.mm

peteatjuce · February 23, 2021, 9:14am

I’ve seen some problems with slower iOS devices not responding to orientation changes, and hence was digging back to the Juce source code to see if there had been any recent fixes in that area.

I see that the most recent commit in develop added a call to forceDisplayUpdate(); in juce_ios_UIViewComponentPeer.mm … but I can’t see that implemented anywhere?

I was wondering what the purpose of this commit was, or if it missed something?

github.com

juce-framework/JUCE/blob/fd83e0f51e33e3fbccb426a09429a18156e767d5/modules/juce_gui_basics/native/juce_ios_UIViewComponentPeer.mm

/*
  ==============================================================================

   This file is part of the JUCE library.
   Copyright (c) 2020 - Raw Material Software Limited

   JUCE is an open source library subject to commercial or open-source
   licensing.

   By using JUCE, you agree to the terms of both the JUCE 6 End-User License
   Agreement and JUCE Privacy Policy (both effective as of the 16th June 2020).

   End User License Agreement: www.juce.com/juce-6-licence
   Privacy Policy: www.juce.com/juce-privacy-policy

   Or: You may also use this code under the terms of the GPL v3 (see
   www.gnu.org/licenses).

   JUCE IS PROVIDED "AS IS" WITHOUT ANY WARRANTY, AND ALL WARRANTIES, WHETHER
   EXPRESSED OR IMPLIED, INCLUDING MERCHANTABILITY AND FITNESS FOR PURPOSE, ARE

This file has been truncated. show original

Best wishes,

Pete

ed95 · February 23, 2021, 9:51am

There shouldn’t be any change in behaviour - ComponentPeer::forceDisplayUpdate() just calls Desktop::getInstance().displays->refresh() replacing the nasty const_cast that was there before. Are your sure that the change isn’t due to any of the other recent iOS changes? Can you do a git bisect to find the actual commit which caused the change in behaviour?

peteatjuce · February 23, 2021, 10:19am

Hi @ed95

I know - this is a really weird one! I’ve not updated the Juce side of our code since I merged-in the Juce 6 code a month or so back.

This is just something that “started happening”. My best guess, is that recent changes to Wotja are taking more CPU, and that somehow affects timings on the Juce/iOS interaction side.

Luckily, the version of the above two files, where I’d implemented my own split screen implementation, before merging-in the Juce 6 versions, work fine with orientation change (and split screen of course). Phew!

I’m going to try to figure out for you what the problem is, and if/as/when I do, I’ll be sure to feed it back to you.

Final thought - if you asked me to speculate what the source of the problem is, I’d guess:
static Rectangle getRecommendedWindowBounds()
… but I’ve yet to investigate!

Best wishes,

Pete

peteatjuce · February 23, 2021, 10:28am

NB I’m talking across myself - this issue is also on iOS Multitasking - #20 by reuk … sorry

Site navigation

juce_ios_UIViewComponentPeer.mm

Further Information