MidiFile: Why no copy operator?


#1

Also, why doesn’t the MidiFile class subclass the File class?


#2

I’ve added a copy constructor and copy assignment operator to MidiFile now on develop, thanks for the suggestion!

The File class isn’t polymorphic so it wouldn’t really make sense for MidiFile to subclass it.

Ed


#3

Where is the development branch on github?

edit: nvm, i found it.


#4

@ed95 I noticed that the MidiFile::writeTo() method never returns false, yet the description says “returns true if the write operation is successful”. Should this be added?


#5

Yep, I’ve added this to develop now. Thanks!

Ed