MidiMessageSequence and note off messages

[leehu]

Hi, I wonder under the impression that there was something to add note off messages to all unmatched note on message but can’t seem to find this.

Was I imagining this?

Thx

[bgporter]

Do you mean a JUCE API call, or CC123 (all notes off)?

[cpr2323]

There is MidiMesasgeSequence::updateMatchedPairs

[leehu]

Yeah, thx - doesn’t actually add missing note off at the end tho. It’s no probs, was easy to implement, just thought it already existed somewhere.

[cpr2323]

I was going to point to the post linked below as why it might be doing something different, but I realized only the copy ctor changed, not the updateMatchedPairs call.

MidiMessageSequence copy constructor has incorrect hidden side-effect

I am manually managing the noteOffObject of the MidiEventHolder as made quite easy with the return value of addEvent (as mentioned in this post from 2012, MidiMessageSequence and updateMatchedPairs). But the copy constructor for MidiMessageSequence has a hidden side effect that breaks this, and actual produces a copy that may not be the same as the source (ie. has noteOffObject filled in, even if the source didn’t). The issue is that the copy constructor calls updateMatchedPairs(). I have a prop…