Recommended warnings thank-you

Just wanted to say thank-you for this! :raised_hands:


It’s made us fix a lot of the corresponding warnings in our codebase too!

I don’t see this for my VS2017 exporter – is it mac only?

macOS and Linux.

Which extra warnings do you enable on Windows?

These ones I found useful in helping keep on par between MSVC, clang, and GCC, alongside the warnings you’ve added. It’s a bit hard to tell but I made them links.


None, I was just wondering if it was missing on Windows by design or if it was an oversight.

@t0m on macOS does this target a specific version of clang? I receive some warnings on Xcode 9.2 when enabling this option:

warning: unknown warning option '-Wzero-as-null-pointer-constant'; did you mean '-Wint-to-void-pointer-cast'? [-Wunknown-warning-option]
warning: unknown warning option '-Winconsistent-missing-destructor-override'; did you mean '-Winconsistent-missing-override'? [-Wunknown-warning-option]