Some nitpicking in OpenGLDemo


#1

Howdy,

I notice this in OpenGLDemo.cpp:

if (OpenGLShaderProgram::Uniform* uni = uniforms->projectionMatrix)
    openGLContext.extensions.glUniformMatrix4fv (uni->uniformID, 1, 0, getProjectionMatrix().mat);

Is there any reason why it's not:

if (uniforms->projectionMatrix)
    uniforms->projectionMatrix->setMatrix4(getProjectionMatrix().mat, 1, 0);

Along with several similar lines..

Cheers, Yair

 


#2

Good point! No idea why it wasn't done that way, I guess I wasn't paying attention when I wrote that bit!