VSTPluginInstance::fillInPluginDescription assertion while scanning plugin


#1

The function KnownPluginList::scanAndAddFile triggers an assert when it scans a plugin which has a non-ASCII manufacturer's name, like Crazy Diamonds by Rumpelrausch Täips.

The assert is triggered because VSTPluginInstance::fillInPluginDescription creates a char[] buffer to contain the manufacturer's name, so it crashes when it tries to copy that buffer in the "manufacturerName" PluginDescription member.

Triggered assert is from juce_String.cpp, line 331: https://github.com/julianstorer/JUCE/blob/master/modules/juce_core/text/juce_String.cpp#L331

Faulty call is from VSTPluginFormat.cpp, line 805: https://github.com/julianstorer/JUCE/blob/master/modules/juce_audio_processors/format_types/juce_VSTPluginFormat.cpp#L805

Am I doing something wrong, is there a way to tell KnownPluginList::scanAndAddFile not to do that ASCII-check?

Thanks for your help.


#2

Thanks - I've updated that so that it now uses UTF8.

But it's important to note that AFAIK Steinberg never actually specified the encoding for these strings, so if you're writing a plugin, it's a risky idea to pass non-ascii text, as there's no guarantee what format the host will treat it as.


#3

Yes, I read that from you in another thread if I remember well.
Thanks for your amazing work and help.