addItem function has the
newItemText parameter first and
newItemId second, which is inconsistent with the same function of the PopupMenu, where
newItemId comes first.
Making changes to comboBoxes can be unnecessarily fiddly, since one has to keep switching the parameters around when moving items to a subMenu or removing them.
Also, this is inconsistent with other functions of ComboBox itself such as
changeItemText, where the
itemId comes first.
Why not simply add an
addItem function with the parameters in the reversed order? It would’t break anything and would make things a bit nicer when using comboBoxes.