Commit broken on develop: "Fixed a Rectangle intersection issue"

[jrlanglois]

Without the rectangle ref, any mutated rect’s properties don’t transmit upwards, effectively breaking the intersectRectangle API’s intention:

Clips a rectangle so that it lies only within this one.

---

Example breakage:

[t0m]

RectangleList:: getIntersectionWith compiler error

Since Array returns const& in foreach loops the later one is broken. Removing the & fixed it for me. bool getIntersectionWith (RectangleType rect, RectangleList& destRegion) const { jassert (rect.isFinite()); // You must provide a valid rectangle to this method! destRegion.clear(); if (! rect.isEmpty()) for (auto**&** r : rects) if (rect.intersectRectangle (r)) destRegion.rects.add (r); return ! destRegion.isEmpty(); }

[jrlanglois]

So, my screenshot is irrelevant, and the API is broken which is totally fine?

[t0m]

Did you read the thread I linked?

“there’s a fix for the fix on the way”, and it’s already been pushed to the public repo.

[jrlanglois]

Just the latter message up front would have sufficed.