Mac MenuBarModel Items gone after 6ae99f4

MacOSX and iOS
1

Just updated my juce repo from 5.1.2 f08aa821b6be6a71f774bf7a163258ac0bbe0a22 to 5.2.0 eb0293a285b2725ca4e90137d26d0ab616df6f9e and noticed that all of my native menu items provided by getAllCommands, getCommandInfo on my child components have disappeared; top level JUCEApplication menu items are still there.

I tracked it down to this commit 6ae99f4343843e8987e1a767b63ba610a1843cdf

Rolling back to c956b984c67f28fed2323f7908904aa7e523b726 right before 6ae99f4343843e8987e1a767b63ba610a1843cdf and all works fine.

Either I’ve been using ApplicationCommandTarget(s) all wrong for the last 10 years or something broke.

2

After some further investigation I found that my menubar items came back after showing any native modal window for example a native File Chooser. Looks like the menu bar model never got an update message…

Adding MenuBarModel::setApplicationCommandManagerToWatch call inside App::initialise fixes the issue.

Why I’ve never had to call MenuBarModel::setApplicationCommandManagerToWatch in my current project will always be on my mind and in my heart.

3

Why I’ve never had to call MenuBarModel::setApplicationCommandManagerToWatch in my current project will always be on my mind and in my heart.

LOL