Strange goings on with latest tip

Linux
1

- The JucePluginDemo but doesn't behave correctly when opened in JUCE-based,or non-Juce based hosts. It appears that as soon as one presses a key on the keyboard component the plugin loses focus and the note stops. Reverting this commit fixes the issue:

https://github.com/julianstorer/JUCE/commit/e0f64bb27ac5e33ee1b2a61787c08e8c7a7c9e42

- While the aforementioned commit did help to ensure JUCE based plugins open with the correct size on non-JUCE based hosts, the issue of JUCE plugins not opening correctly in JUCE-based hosts remains. When the host calls createEditorIfNeeded() with a JUCE based plugin it is more often than not returning an editor with height and size of 1.

Any ideas on how to fix this?

btw, I could recreate the issues fallTx is having with popup displays..

2

Not having a linux plugin dev environment, I'm afraid I mostly rely of you guys for suggestions on this one - ideas welcome!

3

While this is the result of pure guess work, the following change to the vst wrapper(line 1185-ish) seems to fix all of the problems reported above. Plugins now consistently open with the correct size in juce-based hosts (host plugin demo) and non juce-based hosts(renoise, bitwig). Popup displays appear where they should and plugins don't lose focus and can be played through the editor without any issues.

              #elif JUCE_LINUX
                editorComp->addToDesktop (0, ptr);
                hostWindow = (Window) ptr;
                Window editorWnd = (Window) editorComp->getWindowHandle();
                XReparentWindow (display, editorWnd, hostWindow, 0, 0);
              #else

Now if anyone could explain why this fixes everything I'm all ears.

4

Well, I'm happy to make that change if others can confirm it, though I also can't see why it would make any difference!

5

Hi there,
I confirm that this does indeed fixes the window positionning issue.
Rory, you just saved me from more days of debugging, thanks!

6

That was a long time ago. I haven’t noticed the same problems with version 4.