Sudden Projucer (5.4.1) crashes on OSX Mojave

[siedschl]

When trying to create a copy of a configuration, I get a rather obscure crash 90 percent of the time now. Here’s a crash report:
Process: Projucer [3688]
Path: /Applications/Projucer.app/Contents/MacOS/Projucer
Identifier: com.juce.theprojucer
Version: 5.4.1 (5.4.1)
Code Type: X86-64 (Native)
Parent Process: ??? [1]
Responsible: Projucer [3688]
User ID: 503

Date/Time: 2019-02-02 14:04:09.369 +0100
OS Version: Mac OS X 10.14.1 (18B75)
Report Version: 12
Anonymous UUID: E55C0971-A6E1-ACC5-B09E-74653DE3136B

Time Awake Since Boot: 5400 seconds

System Integrity Protection: enabled

Crashed Thread: 0 JUCE Message Thread Dispatch queue: com.apple.main-thread

Exception Type: EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: EXC_I386_GPFLT
Exception Note: EXC_CORPSE_NOTIFY

Termination Signal: Segmentation fault: 11
Termination Reason: Namespace SIGNAL, Code 0xb
Terminating Process: exc handler [3688]

Thread 0 Crashed:: JUCE Message Thread Dispatch queue: com.apple.main-thread
0 com.juce.theprojucer 0x000000010756d5e6 juce::TextPropertyComponent::RemapperValueSourceWithDefault::getValue() const + 22
1 com.juce.theprojucer 0x0000000107406ba9 juce::Value::toString() const + 57
2 com.juce.theprojucer 0x000000010749d534 juce::LookAndFeel_V2::drawLabel(juce::Graphics&, juce::Label&) + 356
3 com.juce.theprojucer 0x00000001074e7e47 juce::Component::paintComponentAndChildren(juce::Graphics&) + 135
4 com.juce.theprojucer 0x00000001074e829c juce::Component::paintComponentAndChildren(juce::Graphics&) + 1244
5 com.juce.theprojucer 0x00000001074e829c juce::Component::paintComponentAndChildren(juce::Graphics&) + 1244
6 com.juce.theprojucer 0x00000001074e829c juce::Component::paintComponentAndChildren(juce::Graphics&) + 1244
7 com.juce.theprojucer 0x00000001074e829c juce::Component::paintComponentAndChildren(juce::Graphics&) + 1244
8 com.juce.theprojucer 0x00000001074e829c juce::Component::paintComponentAndChildren(juce::Graphics&) + 1244
9 com.juce.theprojucer 0x00000001074e829c juce::Component::paintComponentAndChildren(juce::Graphics&) + 1244
10 com.juce.theprojucer 0x00000001074e829c juce::Component::paintComponentAndChildren(juce::Graphics&) + 1244
11 com.juce.theprojucer 0x00000001074e829c juce::Component::paintComponentAndChildren(juce::Graphics&) + 1244
12 com.juce.theprojucer 0x0000000107511fa0 juce::ComponentPeer::handlePaint(juce::LowLevelGraphicsContext&) + 320
13 com.juce.theprojucer 0x000000010750b394 juce::JuceNSViewClass::drawRect(objc_object*, objc_selector*, CGRect) + 516
14 com.apple.AppKit 0x00007fff46530755 _NSViewDrawRect + 66
15 com.apple.AppKit 0x00007fff4652f00d -[NSView(NSInternal) _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:] + 1545
16 com.apple.AppKit 0x00007fff4652e9f2 __46-[NSView(NSLayerKitGlue) drawLayer:inContext:]block_invoke + 192
17 com.apple.AppKit 0x00007fff4652e751 -[NSView(NSLayerKitGlue) drawViewBackingLayer:inContext:drawingHandler:] + 1769
18 com.apple.QuartzCore 0x00007fff53e6ba83 CABackingStoreUpdate + 577
19 com.apple.QuartzCore 0x00007fff53ecc82d invocation function for block in CA::Layer::display() + 53
20 com.apple.QuartzCore 0x00007fff53e6ac78 -[CALayer _display] + 1839
21 com.apple.AppKit 0x00007fff4652dcaa _NSBackingLayerDisplay + 531
22 com.apple.AppKit 0x00007fff46512219 -[_NSViewBackingLayer display] + 811
23 com.apple.QuartzCore 0x00007fff53e6a1a4 CA::Layer::display_if_needed(CA::Transaction*) + 634
24 com.apple.QuartzCore 0x00007fff53e5842f CA::Context::commit_transaction(CA::Transaction*) + 319
25 com.apple.QuartzCore 0x00007fff53e57d00 CA::Transaction::commit() + 576
26 com.apple.QuartzCore 0x00007fff53e57a0c CA::Transaction::observer_callback(__CFRunLoopObserver*, unsigned long, void*) + 66
27 com.apple.CoreFoundation 0x00007fff48f0e6ad CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION + 23
28 com.apple.CoreFoundation 0x00007fff48f0e5e2 __CFRunLoopDoObservers + 452
29 com.apple.CoreFoundation 0x00007fff48eafa64 CFRunLoopRunSpecific + 523
30 com.apple.HIToolbox 0x00007fff48148b35 RunCurrentEventLoopInMode + 293
31 com.apple.HIToolbox 0x00007fff4814886b ReceiveNextEventCommon + 618
32 com.apple.HIToolbox 0x00007fff481485e8 _BlockUntilNextEventMatchingListInModeWithFilter + 64
33 com.apple.AppKit 0x00007fff46404eb7 _DPSNextEvent + 997
34 com.apple.AppKit 0x00007fff46403c56 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1362
35 com.apple.AppKit 0x00007fff463fdcb9 -[NSApplication run] + 699
36 com.juce.theprojucer 0x00000001071360ae main + 430
37 libdyld.dylib 0x00007fff7609208d start + 1

Thread 1:
0 libsystem_pthread.dylib 0x00007fff76283428 start_wqthread + 0
1 ??? 0x0000000054485244 0 + 1414025796

Thread 2:: Pool
0 libsystem_kernel.dylib 0x00007fff761ce1b2 __psynch_cvwait + 10
1 libsystem_pthread.dylib 0x00007fff762875cb _pthread_cond_wait + 724
2 com.juce.theprojucer 0x00000001073be1de juce::WaitableEvent::wait(int) const + 190
3 com.juce.theprojucer 0x00000001073f9a9e juce::ThreadPool::ThreadPoolThread::run() + 782
4 com.juce.theprojucer 0x00000001073cb256 juce::threadEntryProc(void*) + 390
5 libsystem_pthread.dylib 0x00007fff76284339 _pthread_body + 126
6 libsystem_pthread.dylib 0x00007fff762872a7 _pthread_start + 70
7 libsystem_pthread.dylib 0x00007fff76283445 thread_start + 13

Thread 3:: Pool
0 libsystem_kernel.dylib 0x00007fff761ce1b2 __psynch_cvwait + 10
1 libsystem_pthread.dylib 0x00007fff762875cb _pthread_cond_wait + 724
2 com.juce.theprojucer 0x00000001073be1de juce::WaitableEvent::wait(int) const + 190
3 com.juce.theprojucer 0x00000001073f9a9e juce::ThreadPool::ThreadPoolThread::run() + 782
4 com.juce.theprojucer 0x00000001073cb256 juce::threadEntryProc(void*) + 390
5 libsystem_pthread.dylib 0x00007fff76284339 _pthread_body + 126
6 libsystem_pthread.dylib 0x00007fff762872a7 _pthread_start + 70
7 libsystem_pthread.dylib 0x00007fff76283445 thread_start + 13

Thread 4:: Dispatch queue: NSCGSDisableUpdates
0 libsystem_kernel.dylib 0x00007fff761cac2a mach_msg_trap + 10
1 libsystem_kernel.dylib 0x00007fff761cb174 mach_msg + 60
2 com.apple.SkyLight 0x00007fff6efbdc37 CGSUpdateManager::enable_updates_common() + 539
3 com.apple.SkyLight 0x00007fff6ef6107f CGSUpdateManager::enable_update(unsigned long long) + 317
4 libdispatch.dylib 0x00007fff76042d53 _dispatch_call_block_and_release + 12
5 libdispatch.dylib 0x00007fff76043dcf _dispatch_client_callout + 8
6 libdispatch.dylib 0x00007fff7604a124 _dispatch_lane_serial_drain + 618
7 libdispatch.dylib 0x00007fff7604abdc _dispatch_lane_invoke + 388
8 libdispatch.dylib 0x00007fff76053090 _dispatch_workloop_worker_thread + 603
9 libsystem_pthread.dylib 0x00007fff7628363c _pthread_wqthread + 409
10 libsystem_pthread.dylib 0x00007fff76283435 start_wqthread + 13

Thread 5:
0 libsystem_pthread.dylib 0x00007fff76283428 start_wqthread + 0
1 ??? 0x0000000054485244 0 + 1414025796

Thread 6:
0 libsystem_pthread.dylib 0x00007fff76283428 start_wqthread + 0
1 ??? 0x0000000054485244 0 + 1414025796

Thread 7:: com.apple.NSEventThread
0 libsystem_kernel.dylib 0x00007fff761cac2a mach_msg_trap + 10
1 libsystem_kernel.dylib 0x00007fff761cb174 mach_msg + 60
2 com.apple.CoreFoundation 0x00007fff48eb0da2 __CFRunLoopServiceMachPort + 337
3 com.apple.CoreFoundation 0x00007fff48eb02f1 __CFRunLoopRun + 1654
4 com.apple.CoreFoundation 0x00007fff48eafa28 CFRunLoopRunSpecific + 463
5 com.apple.AppKit 0x00007fff4640dadd _NSEventThread + 160
6 libsystem_pthread.dylib 0x00007fff76284339 _pthread_body + 126
7 libsystem_pthread.dylib 0x00007fff762872a7 _pthread_start + 70
8 libsystem_pthread.dylib 0x00007fff76283445 thread_start + 13

Thread 8:: JUCE Timer
0 libsystem_kernel.dylib 0x00007fff761ce1b2 __psynch_cvwait + 10
1 libsystem_pthread.dylib 0x00007fff762875cb _pthread_cond_wait + 724
2 com.juce.theprojucer 0x00000001073be1de juce::WaitableEvent::wait(int) const + 190
3 com.juce.theprojucer 0x00000001074153fb juce::TimerThread::run() + 171
4 com.juce.theprojucer 0x00000001073cb256 juce::threadEntryProc(void*) + 390
5 libsystem_pthread.dylib 0x00007fff76284339 _pthread_body + 126
6 libsystem_pthread.dylib 0x00007fff762872a7 _pthread_start + 70
7 libsystem_pthread.dylib 0x00007fff76283445 thread_start + 13

Thread 9:: Pool
0 libsystem_kernel.dylib 0x00007fff761ce1b2 __psynch_cvwait + 10
1 libsystem_pthread.dylib 0x00007fff762875cb _pthread_cond_wait + 724
2 com.juce.theprojucer 0x00000001073be1de juce::WaitableEvent::wait(int) const + 190
3 com.juce.theprojucer 0x00000001073f9a9e juce::ThreadPool::ThreadPoolThread::run() + 782
4 com.juce.theprojucer 0x00000001073cb256 juce::threadEntryProc(void*) + 390
5 libsystem_pthread.dylib 0x00007fff76284339 _pthread_body + 126
6 libsystem_pthread.dylib 0x00007fff762872a7 _pthread_start + 70
7 libsystem_pthread.dylib 0x00007fff76283445 thread_start + 13

Thread 10:: License
0 libsystem_kernel.dylib 0x00007fff761ce1b2 __psynch_cvwait + 10
1 libsystem_pthread.dylib 0x00007fff762875cb _pthread_cond_wait + 724
2 com.juce.theprojucer 0x00000001073be1de juce::WaitableEvent::wait(int) const + 190
3 com.juce.theprojucer 0x0000000107224458 LicenseThread::run() + 248
4 com.juce.theprojucer 0x00000001073cb256 juce::threadEntryProc(void*) + 390
5 libsystem_pthread.dylib 0x00007fff76284339 _pthread_body + 126
6 libsystem_pthread.dylib 0x00007fff762872a7 _pthread_start + 70
7 libsystem_pthread.dylib 0x00007fff76283445 thread_start + 13

Thread 11:: com.apple.NSURLConnectionLoader
0 libsystem_kernel.dylib 0x00007fff761cac2a mach_msg_trap + 10
1 libsystem_kernel.dylib 0x00007fff761cb174 mach_msg + 60
2 com.apple.CoreFoundation 0x00007fff48eb0da2 __CFRunLoopServiceMachPort + 337
3 com.apple.CoreFoundation 0x00007fff48eb02f1 __CFRunLoopRun + 1654
4 com.apple.CoreFoundation 0x00007fff48eafa28 CFRunLoopRunSpecific + 463
5 com.apple.CFNetwork 0x00007fff47db24e5 -[__CoreSchedulingSetRunnable runForever] + 195
6 com.apple.Foundation 0x00007fff4b20c014 NSThread__start + 1218
7 libsystem_pthread.dylib 0x00007fff76284339 _pthread_body + 126
8 libsystem_pthread.dylib 0x00007fff762872a7 _pthread_start + 70
9 libsystem_pthread.dylib 0x00007fff76283445 thread_start + 13

Thread 0 crashed with X86 Thread State (64-bit):
rax: 0x34352e3331203835 rbx: 0x00007ffee8b6cdb8 rcx: 0x00007ffee8b6cd90 rdx: 0x0000000500000001
rdi: 0x00007ffee8b6cdb8 rsi: 0x00007fb71c91e2e0 rbp: 0x00007ffee8b6cda0 rsp: 0x00007ffee8b6cd90
r8: 0x3ff0000000000000 r9: 0x0000000000000000 r10: 0x0000600001585598 r11: 0xffffe00118a2d2a0
r12: 0x0000000000000316 r13: 0x00007fb71c43eb50 r14: 0x0000000000000063 r15: 0x00007ffee8b6ce10
rip: 0x000000010756d5e6 rfl: 0x0000000000010206 cr2: 0x00007fb71c4490b8

[reuk]

I can’t reproduce this using the Projucer from develop and address sanitizer.

Are you definitely using the Projucer from the develop branch?

If so, what are the exact steps you’re taking which cause the crash?

[siedschl]

No, I’m using the latest Release Projucer…

[reuk]

As it seems that the bug is already fixed on develop, I’d recommend switching branches for the time being if this is affecting your workflow.

[siedschl]

Ok, thanks.

[rdthompson]

It’s June 7, 2019 and I still get this similar problem on JUCE 5.4.3

MainThread (1): signal SIGSEGV e.g. EXC_BAD_ACCESS (SIGSEGV)

Seems like a lot of confusion in upgrading to modern memory management in JUCE.

When creating:
instanceOfType = std::make_unique<ObjectOfType>( );

When defining member variable:
std::unique_ptr<ObjectOfType> instanceOfType;

When accessing:
((std::unique_ptr<ObjectOfType>)instanceOfType.get( ));

[reuk]

What steps can I take to reproduce the issue?

(Please don’t use C casts on unique_ptrs.)

[rdthompson]

I’ll try to come up with a small example later. Right now it’s part of a class where it was obvious that the code was from earlier JUCE modules, and now at the end, we’re supposed to update it.

[rdthompson]

Can you be more specific? Are you referring to the required type?

Or the use of parenthesis in the 3rd example?

If you could kindly suggest an alternative to which of these or all of them need to be written otherwise, it would help.

[reuk]

When accessing a unique_ptr, most of the time you can just dereference it like a normal ptr:

std::unique_ptr<Component> comp;
...
comp = std::make_unique<Component>();
comp->setName ("newName");
addAndMakeVisible (*comp);

If you do need to use the raw pointer for some reason, just comp.get() is sufficient, there’s no need to do any casting (with parentheses or otherwise).

[daniel]

Just to add, when you need to cast, you do it on the raw pointer, not the unique_ptr object, which is just a wrapper around the raw pointer. And like @reuk said, use the safe C++ variants:

std::unique_ptr<ObjectType> thing;
if (auto* derrived = dynamic_cast<DerrivedObjectType*>(thing.get()))
{
    derrived->foo();
}

this will check, if your object is actually of type DerrivedObjectType and return nullptr instead.
The version you chose will assume there is an object of DerrivedObjectType at the given address, and call methods that may or may not be there, so this is instantly undefined behaviour.

N.B. a C-style cast translates in C++ to a reinterpret_cast… all alarm bells should go off in your code, if you use that…