ValueTree <=> JSON

[eluke309]

I would recommend leaving the flag on - otherwise implicit conversion from raw to smart pointers might happen in the shadows, as better explained by Jules on this post:

New flag to help avoid smart-pointer accidents: JUCE_STRICT_REFCOUNTEDPOINTER

The old ReferenceCountedObjectPtr class is pretty ancient, and when I wrote it, I made it pretty lenient in terms of what it allows you to do with it - in particular, it has a cast operator that allows it to be implicitly cast into a raw pointer to the underlying object. Now, that may seem like a pretty sensible thing to do, as it means you can pretty much mix smart-pointers with raw pointers with very little syntax. However, having spotted a lot of places where raw and smart pointers are being…

The way around it is to change the line:
result->setProperty (child.getType(), var (valueTreeToJsonObj (child)));
to
result->setProperty (child.getType(), var ((valueTreeToJsonObj (child)).get()));