Incorrect #undef of JUCE_USE_CAMERA


#1

Presently, JUCE #undefs JUCE_USE_CAMERA when not building for macOS or Windows.

#if ! (JUCE_MAC || JUCE_WINDOWS)
 #undef JUCE_USE_CAMERA
#endif

Thing is, the framework supports this feature on both on macOS, iOS, Windows, and Android if you look at the implementation file:

#if JUCE_MAC || JUCE_IOS
 #include "../native/juce_mac_CameraDevice.h"
#elif JUCE_WINDOWS
 #include "../native/juce_win32_CameraDevice.h"
#elif JUCE_ANDROID
 #include "../native/juce_android_CameraDevice.h"
#endif

Looks like it should just be #undeffing on Linux?

#if JUCE_LINUX || JUCE_BSD
 #undef JUCE_USE_CAMERA
#endif

#2

The Android implementation file is dummy at the moment, and as far as I can tell, iOS support is not finished either, as mentioned in Android and iOS Camera Support hence it’s probably okay to have JUCE_USE_CAMERA disabled on iOS and Android for the time being.


#3

Ah, I didn’t get the chance to dig too much as I was on mobile at the time.

Thanks for clearing that up!